[U-Boot] [PATCH v2 09/16] arm: dts: dra7: add qspi register maps for memory map and control module

[Mugunthan V N]

On Monday 16 November 2015 07:43 AM, Tom Rini wrote:
> On Sat, Nov 14, 2015 at 01:01:45PM +0530, Mugunthan V N wrote:
>> On Thursday 12 November 2015 06:17 PM, Tom Rini wrote:
>>> On Thu, Nov 12, 2015 at 02:33:48PM +0530, Mugunthan V N wrote:
>>>> On Sunday 08 November 2015 07:01 PM, Tom Rini wrote:
>>>>> On Wed, Nov 04, 2015 at 01:46:17PM +0530, Mugunthan V N wrote:
>>>>>
>>>>>> Add qspi memory map and control module register maps to device tree.
>>>>>>
>>>>>> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
>>>>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>>>> ---
>>>>>>  arch/arm/dts/dra7.dtsi | 4 ++--
>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/arm/dts/dra7.dtsi b/arch/arm/dts/dra7.dtsi
>>>>>> index 3060e9a..7045c0f 100644
>>>>>> --- a/arch/arm/dts/dra7.dtsi
>>>>>> +++ b/arch/arm/dts/dra7.dtsi
>>>>>> @@ -1104,8 +1104,8 @@
>>>>>>  
>>>>>>  		qspi: qspi at 4b300000 {
>>>>>>  			compatible = "ti,dra7xxx-qspi";
>>>>>> -			reg = <0x4b300000 0x100>;
>>>>>> -			reg-names = "qspi_base";
>>>>>> +			reg = <0x4b300000 0x100>, <0x5c000000 0x4000000>, <0x4a002558 0x4>;
>>>>>> +			reg-names = "qspi_base", "qspi_mmap", "qspi_ctrlmod";
>>>>>>  			#address-cells = <1>;
>>>>>>  			#size-cells = <0>;
>>>>>>  			ti,hwmods = "qspi";
>>>>>
>>>>> Is this already upstream?
>>>>>
>>>>
>>>> The documentation part is already upstreamed. Driver in kernel doesn't
>>>> support mmap mode yet so dt changes are not present. Vignesh has
>>>> submitted the mmap patches [1] and is under review.
>>>>
>>>> [1]: https://lkml.org/lkml/2015/11/10/14
>>>
>>> OK, and we can't even get the reg names part in the DT upstream until
>>> then?
>>>
>>
>> I don't think we can get reg names in the DT upstream separately. But
>> there shouldn't be any issues as there is documentation already present
>> in kernel and submitted kernel patch DT nodes are similar to what I have
>> submitted.
> 
> Similar or the same?  We'll be dropping in (and quick diff'ing) a new DT
> from the kernel at some point in the future.  So if there's chance of
> things changing, we want to wait.
> 

Its Similar now, will make it Same in next version

Regards
Mugunthan V N