[U-Boot] [PATCH 14/25] dm: tegra: net: Convert tegra boards to driver model for Ethernet

[Simon Glass]

Hi Stephen,

On 18 November 2015 at 14:35, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 11/16/2015 08:53 PM, Simon Glass wrote:
>>
>> Adjust all Tegra boards to use driver model for Ethernet, now that the
>> required drivers are converted.
>
>
>> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
>
>
>> @@ -14,6 +14,7 @@ config TEGRA_ARMV7_COMMON
>>         select DM_GPIO
>>         select DM_PCI
>>         select DM_PCI_COMPAT
>> +       select DM_ETH
>
>
> This should be set for Tegra210 too. I suggest creating a "config
> TEGRA_COMMON" to contain all the shared settings, and making
> TEGRA_ARMV7_COMMON and TEGRA_ARMV8_COMMON (also new) select that.

Would you mind doing a patch for that? It seems like it should be a
separate patch.

>
>> diff --git a/board/compulab/trimslice/trimslice.c
>> b/board/compulab/trimslice/trimslice.c
>
>
>> -#ifdef CONFIG_PCI
>> -int board_eth_init(bd_t *bis)
>> -{
>> -       return pci_eth_init(bis);
>> -}
>> -#endif
>
>
> Has the need to call this function already been removed by this point in the
> series. In other words, does each commit in this series compile and support
> using Ethernet? If not, anyone running "git bisect" is going to be very sad.

It's connected with CONFIG_DM_ETH, so we should be OK.

Regards,
Simon