[U-Boot] [RESEND PATCH v5 1/6] cgtqmx6eval: Add SPI NOR flash support

Jagan Teki jteki at openedev.com
Thu Nov 19 16:49:21 CET 2015


On 19 November 2015 at 20:12, Fabio Estevam <festevam at gmail.com> wrote:
> On Thu, Nov 19, 2015 at 6:27 AM, Jagan Teki <jteki at openedev.com> wrote:
>
>> Since it's u-boot, size is main constraint ie the main reason to use
>> ifdef and also this initialization code must be part of driver probe
>> instead of board file, once the driver moved to dm then will move this
>> as well so to indicate that this could be a driver code better to use
>> the driver config in #ifdef.
>
> In this board CONFIG_SPI_MXC will always be selected, so size
> constraint does not apply here.

I'm saying about setup_spinor init code see  "grep -R CONFIG_MXC_SPI
board/ " how they defined.

>
>> See this
>> $ grep -R CONFIG_MXC_SPI board/
>>
>> And use setup_spi instead of setup_spinor
>
> What is the reason for that?

Because this is spi controller setup not the spi_nor - please see the
boards which uses CONFIG_MXC_SPI

$ grep -R CONFIG_MXC_SPI board/

thanks!
-- 
Jagan | openedev.


More information about the U-Boot mailing list