[U-Boot] [PATCH v2 03/13] pci: Refactor the pciinfo() function

Bin Meng bmeng.cn at gmail.com
Mon Nov 23 03:44:44 CET 2015


On Sun, Nov 22, 2015 at 7:28 AM, Simon Glass <sjg at chromium.org> wrote:
> This function uses macros to output data. It seems better to use a table of
> registers rather than macro-based code generation. It also reduces the
> code/data size by 2KB on ARM.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> ---
>
> Changes in v2:
> - Squash in the patch to fix pci_field_width() for 32-bit values
> - Rename '_byte' to class in pci_header_show()
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>

>  common/cmd_pci.c | 237 ++++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 148 insertions(+), 89 deletions(-)
>

[snip]

Regards,
Bin


More information about the U-Boot mailing list