[U-Boot] [PATCH v2 08/13] pci: Tidy up function comments in cmd_pci.c

Bin Meng bmeng.cn at gmail.com
Mon Nov 23 03:44:55 CET 2015


Hi Simon,

On Sun, Nov 22, 2015 at 7:28 AM, Simon Glass <sjg at chromium.org> wrote:
> The function comments use an old style and some are incorrect. Update them.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2:
> - Add a new patch to update the function comments
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

But please see one nits below.

>  common/cmd_pci.c | 84 ++++++++++++++++++++++++++------------------------------
>  1 file changed, 39 insertions(+), 45 deletions(-)
>
> diff --git a/common/cmd_pci.c b/common/cmd_pci.c
> index f8faa31..7b83c1d 100644
> --- a/common/cmd_pci.c
> +++ b/common/cmd_pci.c
> @@ -161,15 +161,10 @@ static struct pci_reg_info regs_cardbus[] = {
>         {},
>  };
>
> -/*
> - * Subroutine:  PCI_Header_Show
> - *
> - * Description: Reads the header of the specified PCI device.
> - *
> - * Inputs:             BusDevFunc      Bus+Device+Function number
> - *
> - * Return:      None
> +/**
> + * @pci_header_show() - Shows the header of the specified PCI device.

nits: Shows -> Show

>   *
> + * @dev: Bus+Device+Function number
>   */
>  void pci_header_show(pci_dev_t dev)
>  {
> @@ -200,16 +195,12 @@ void pci_header_show(pci_dev_t dev)
>      }
>  }

[snip]

Regards,
Bin


More information about the U-Boot mailing list