[U-Boot] [PATCH 3/4 v2] lib/tiny-printf.c: Add tiny printf function for space limited environments
Stefan Roese
sr at denx.de
Mon Nov 23 06:50:35 CET 2015
Hi Tom,
On 21.11.2015 04:27, Tom Rini wrote:
> On Mon, Nov 16, 2015 at 03:26:33PM +0100, Stefan Roese wrote:
>
>> This patch adds a small printf() version that supports all basic formats.
>> Its intented to be used in U-Boot SPL versions on platforms with very
>> limited internal RAM sizes.
>>
>> To enable it, just define CONFIG_USE_TINY_PRINTF in your defconfig. This
>> will result in the SPL using this tiny function and the main U-Boot
>> still using the full-blown printf() function.
>>
>> This code was copied from:
>> http://www.sparetimelabs.com/printfrevisited
>> With mostly only coding style related changes so that its checkpatch
>> clean.
>>
>> The size reduction is about 2.5KiB. Here a comparison for the db-mv784mp-gp
>> (Marvell AXP) SPL:
>>
>> Without this patch:
>> 58963 18536 1928 79427 13643 ./spl/u-boot-spl
>>
>> With this patch:
>> 56542 18536 1956 77034 12cea ./spl/u-boot-spl
>>
>> Note:
>> To make it possible to compile tiny-printf.c instead of vsprintf.c when
>> CONFIG_USE_TINY_PRINTF is defined, the functions printf() and vprintf() are
>> moved from common/console.c into vsprintf.c in this patch.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Hans de Goede <hdegoede at redhat.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: Albert Aribaud <albert.u.boot at aribaud.net>
>
> This doesn't quite apply now, somehow and my attempt at making it apply
> was either somehow wrong, or there's other problems with the series:
> +(PMC440,lschlv2,zynq_zc702,zynq_zed,zynq_zc706,lsxhl,zynq_picozed,zynq_zybo) examples/a
> pi/vsprintf.o: In function `printf':
> +(PMC440,lschlv2,zynq_zc702,zynq_zed,zynq_zc706,lsxhl,zynq_picozed,zynq_zybo) build/../l
> ib/vsprintf.c:865: multiple definition of `printf'
> +(PMC440,lschlv2,zynq_zc702,zynq_zed,zynq_zc706,lsxhl,zynq_picozed,zynq_zybo) examples/a
> pi/libgenwrap.o:build/../examples/api/libgenwrap.c:23: first defined here
>
> And smartweb has a longer and different failure.
Ah, thanks for checking. I hope that I've now fixed all issues with
this tiny-printf implementation. v3 will follow shortly.
Thanks,
Stefan
More information about the U-Boot
mailing list