[U-Boot] [U-Boot, v2, 4/5] gpt: part: Definition and declaration of GPT verification functions

[Tom Rini]

On Tue, Nov 24, 2015 at 10:56:41AM +0100, Przemyslaw Marczak wrote:
> Hello Tom,
> 
> On 11/23/2015 11:44 PM, Tom Rini wrote:
> >On Fri, Nov 20, 2015 at 08:06:16AM +0100, Lukasz Majewski wrote:
> >
> >>This commit provides definition and declaration of GPT verification
> >>functions - namely gpt_verify_headers() and gpt_verify_partitions().
> >>The former is used to only check CRC32 of GPT's header and PTEs.
> >>The latter examines each partition entry and compare attributes such as:
> >>name, start offset and size with ones provided at '$partitions' env
> >>variable.
> >>
> >>Signed-off-by: Lukasz Majewski <l.majewski at majess.pl>
> >>Reviewed-by: Tom Rini <trini at konsulko.com>
> >>Reviewed-by: Przemyslaw Marczak <p.marczak at samsung.com>
> >
> >Applied to u-boot/master, thanks!
> >
> >
> >
> >_______________________________________________
> >U-Boot mailing list
> >U-Boot at lists.denx.de
> >http://lists.denx.de/mailman/listinfo/u-boot
> >
> 
> Why merged so quickly?
> 
> I tested this patchset on my device and posted about the issues. [1]
> 
> This should be reworked, since the verify assumptions are too simple
> and doesn't fully match the GPT header creation.
> So this command will fail for some cases of write/verify sequence,
> depending on what the $partitions includes.
> 
> [1] https://www.mail-archive.com/u-boot@lists.denx.de/msg193216.html

Mainly because I skimmed things too quickly, sorry.  Also in the future
(and this applies to anyone that's a custodian, and people can also
manage their own patches if they login) please update patches you're
asking for changes on in patchwork, it really does help me keep an eye
on things.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151124/6054d188/attachment.sig>