[U-Boot] [PATCH] usb: xhci: Fix vendor command error if the request type is USB_REQ_SET_ADDRESS or USB_REQ_SET_CONFIGURATION.

Anand Moon linux.amoon at gmail.com
Wed Nov 25 10:09:45 CET 2015


Hi Ted,

On 25 November 2015 at 11:27, Ted Chen <tedchen at realtek.com> wrote:
> Add a condition of set_address and set_configuration to check
> if the request is standardized.
>
> Signed-off-by: Ted Chen <tedchen at realtek.com>
> ---
>  drivers/usb/host/xhci.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index ca598aa..cb8a04b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -941,10 +941,12 @@ static int _xhci_submit_control_msg(struct usb_device *udev, unsigned long pipe,
>         if (usb_pipedevice(pipe) == ctrl->rootdev)
>                 return xhci_submit_root(udev, pipe, buffer, setup);
>
> -       if (setup->request == USB_REQ_SET_ADDRESS)
> +       if (setup->request == USB_REQ_SET_ADDRESS &&
> +          (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD)
>                 return xhci_address_device(udev, root_portnr);
>
> -       if (setup->request == USB_REQ_SET_CONFIGURATION) {
> +       if (setup->request == USB_REQ_SET_CONFIGURATION &&
> +          (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD) {
>                 ret = xhci_set_configuration(udev);
>                 if (ret) {
>                         puts("Failed to configure xHCI endpoint\n");
> --
> 1.7.9.5
>

Tested on Odroid-XU4 with Ethernet USB3.0 RT8153-VB.

Tested-by: Anand Moon <linux.amoon at gmail.com>
Reviewed-by: Anand Moon <linux.amoon at gmail.com>

-Anand Moon


More information about the U-Boot mailing list