[U-Boot] [PATCH] pmic: Fix pfuze100 bit definitions

Vagrant Cascadian vagrant at aikidev.net
Thu Nov 26 00:54:08 CET 2015


On 2015-11-25, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan at freescale.com>
> Date:   Fri Aug 7 16:43:45 2015 +0800
>
>     power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> Cc: Peng Fan <Peng.Fan at freescale.com>
> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> Cc: Tim Harvey <tharvey at gateworks.com>
> Cc: Vagrant Cascadian <vagrant at aikidev.net>
> ---
>  include/power/pfuze100_pmic.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Tested on a Novena PVT2-A, fixes USB support.

Tested-by: Vagrant Cascadian <vagrant at aikidev.net>

live well,
  vagrant

> diff --git a/include/power/pfuze100_pmic.h b/include/power/pfuze100_pmic.h
> index 41cb710..cc019a9 100644
> --- a/include/power/pfuze100_pmic.h
> +++ b/include/power/pfuze100_pmic.h
> @@ -215,10 +215,10 @@ enum {
>  #define SWBST_VOL_MASK	0x3
>  #define SWBST_MODE_MASK	0xC
>  #define SWBST_MODE_SHIFT 0x2
> -#define SWBST_MODE_OFF	0
> -#define SWBST_MODE_PFM	1
> -#define SWBST_MODE_AUTO	2
> -#define SWBST_MODE_APS	3
> +#define SWBST_MODE_OFF	(0 << 2)
> +#define SWBST_MODE_PFM	(1 << 2)
> +#define SWBST_MODE_AUTO	(2 << 2)
> +#define SWBST_MODE_APS	(3 << 2)
>  
>  /*
>   * Regulator Mode Control
> -- 
> 2.6.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151125/9e1987da/attachment.sig>


More information about the U-Boot mailing list