[U-Boot] [PATCH 07/10][v4] driver: net: fsl-mc: Add DPAA2 commands to manage MC

[York Sun]

On 11/03/2015 10:55 PM, Prabhakar Kushwaha wrote:
> Management complex Firmware, DPL and DPC are depolyed during u-boot boot
> sequence.
> 
> Add new DPAA2 commands to manage Management Complex (MC) i.e. start mc, aiop
> and apply DPL from u-boot command prompt.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
>  Changes for v2: Sending as it is
>  Changes for v3: fix compilation for ls2085_emu target
>  Changes for v4: Sending as it is
> 
>  arch/arm/cpu/armv8/fsl-layerscape/README.lsch3 |  30 ++
>  drivers/net/fsl-mc/mc.c                        | 382 ++++++++++++-------------
>  include/configs/ls2085aqds.h                   |  12 -
>  include/configs/ls2085ardb.h                   |  12 -
>  include/fsl-mc/fsl_mc.h                        |   5 +
>  include/fsl-mc/fsl_mc_private.h                |   2 +-
>  6 files changed, 220 insertions(+), 223 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/README.lsch3 b/arch/arm/cpu/armv8/fsl-layerscape/README.lsch3
> index 03e18f6..d1f92c4 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/README.lsch3
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/README.lsch3
> @@ -242,3 +242,33 @@ MMU Translation Tables
>                            | 0x81_0000_0000 |        | 0x08_0080_0000 |
>                            ------------------        ------------------
>  			         ...	                   ...
> +
> +
> +DPAA2 commands to manage Management complex
> +-------------------------------------------
> +Management complex Firmware, DPL and DPC are depolyed during u-boot boot
> +sequence.
> +
> +New DPAA2 commands has been added to manage Management Complex (MC) i.e.
> +start mc, aiop and apply DPL from command prompt.
> +
> +a) fsl_mc start mc [FW_addr] [DPC_addr] - Start Management Complex
> +b) fsl_mc apply DPL [DPL_addr] - Apply DPL file
> +c) fsl_mc start aiop [FW_addr] - Start AIOP
> +
> +u-boot etherenet support sequence :-
> +a) fsl_mc start mc [FW_addr] [DPC_addr] - Start Management Complex
> +b) DPMACs device will be available now for use
> +
> +Linux boot sequence :-
> +a) fsl_mc start mc [FW_addr] [DPC_addr] - Start Management Complex
> +b) fsl_mc apply DPL [DPL_addr] - Apply DPL file
> +c) No DPMACs availabe for use in u-boot
> +c) boot Linux
> +
> +AIOP boot sequence :-
> +a) fsl_mc start mc [FW_addr] [DPC_addr] - Start Management Complex
> +b) fsl_mc start aiop [FW_addr] - Start AIOP
> +c) fsl_mc apply DPL [DPL_addr] - Apply DPL file
> +d) No DPMACs availabe for use in u-boot

Prabhakar,

The help message is not accurate. The FW_addr and DPC_addr are not optional, are
they? If a user must provide the address, please put the format as

fsl_mc start mc <FW_addr> <DPC_addr>

The [] means optional, <> means mandatory. I am using the old school convention,
hopefully the rest of the world agrees with me.

This change is relative big for using MC. I would appreciate some command
examples with real address in README and in commit message. It is helpful for
the transition.

York