[U-Boot] [PATCH v7 13/34] sf: Re-factorize spi_flash_probe_tail code

Simon Glass sjg at chromium.org
Thu Nov 26 18:50:35 CET 2015


Hi Jagan,

On 26 November 2015 at 04:03, Jagan Teki <jteki at openedev.com> wrote:
> spi_flash_probe_tail code looks not in proper shape
> to add more functionalities. hence refactorized
> so-that it's more readable and hence we may extend
> more functionalies to it.
>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: Troy Kisky <troy.kisky at boundarydevices.com>
> Signed-off-by: Jagan Teki <jteki at openedev.com>
> ---
>  drivers/mtd/spi/sf_internal.h |  3 +-
>  drivers/mtd/spi/sf_ops.c      |  7 ++--
>  drivers/mtd/spi/sf_probe.c    | 74 ++++++++++++++++++-------------------------
>  3 files changed, 34 insertions(+), 50 deletions(-)

This relies on the early patch which I believe is not a good plan.
>From what I can see the SPI MTD code does not support driver model, so
that should be sorted out first.

- Simon


More information about the U-Boot mailing list