[U-Boot] [PATCH v3 08/13] pci: Tidy up function comments in cmd_pci.c

Simon Glass sjg at chromium.org
Sat Nov 28 17:55:36 CET 2015


On 26 November 2015 at 23:37, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Fri, Nov 27, 2015 at 10:51 AM, Simon Glass <sjg at chromium.org> wrote:
>> The function comments use an old style and some are incorrect. Update them.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>> Changes in v3:
>> - Use 'Show' instead of 'Shows' in the the pci_header_show() function comment
>>
>> Changes in v2:
>> - Add a new patch to update the function comments
>>
>>  common/cmd_pci.c | 84 ++++++++++++++++++++++++++------------------------------
>>  1 file changed, 39 insertions(+), 45 deletions(-)
>>
>> diff --git a/common/cmd_pci.c b/common/cmd_pci.c
>> index f8faa31..7fdd3d8 100644
>> --- a/common/cmd_pci.c
>> +++ b/common/cmd_pci.c
>> @@ -161,15 +161,10 @@ static struct pci_reg_info regs_cardbus[] = {
>>         {},
>>  };
>>
>> -/*
>> - * Subroutine:  PCI_Header_Show
>> - *
>> - * Description: Reads the header of the specified PCI device.
>> - *
>> - * Inputs:             BusDevFunc      Bus+Device+Function number
>> - *
>> - * Return:      None
>> +/**
>> + * @pci_header_show() - Show the header of the specified PCI device.
>
> nits: please remove @ before pci_header_show().
> Sorry I missed this in previous review. Please fix it when applying.
>

Fixed, and

Applied to u-boot-dm.


More information about the U-Boot mailing list