[U-Boot] [PATCH] ns16550: change reg-shift property default to zero

[Bin Meng]

On Sun, Nov 29, 2015 at 2:01 PM, Thomas Chou <thomas at wytron.com.tw> wrote:
> Change reg-shift property default to zero. When the integer property
> is missing, it should be taken as zero. This is consistent to Linux
> drivers/tty/serial/of_serial.c.
>
> The x86 and most powerpc use reg-shift of 0. Most others use reg-shift
> of 2. While reg-shift of 1 is rarely used.
>
> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
> ---
>  drivers/serial/ns16550.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index d5bcbc3..5b64f7c 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -403,7 +403,7 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
>
>         plat->base = addr;
>         plat->reg_shift = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
> -                                        "reg-shift", 1);
> +                                        "reg-shift", 0);
>         plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>                                      "clock-frequency",
>                                      CONFIG_SYS_NS16550_CLK);
> --

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>