[U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

[Simon Glass]

Hi Marek,

On 28 November 2015 at 18:05, Marek Vasut <marex at denx.de> wrote:
> On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote:
>> Hi Marek,
>>
>> On 27 November 2015 at 11:41, Marek Vasut <marex at denx.de> wrote:
>> > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote:
>> >> Hi,
>> >>
>> >> On 26 November 2015 at 23:22, Chin Liang See <clsee at altera.com> wrote:
>> >> > Enable SDMMC calibration to determine the best setting for
>> >> > drvsel and smplsel. Calibration will be triggered if the
>> >> > drvsel and smplsel node are not available in DTS.
>> >> >
>> >> > Signed-off-by: Chin Liang See <clsee at altera.com>
>> >> > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
>> >> > Cc: Dinh Nguyen <dinh.linux at gmail.com>
>> >> > Cc: Pavel Machek <pavel at denx.de>
>> >> > Cc: Marek Vasut <marex at denx.de>
>> >> > Cc: Stefan Roese <sr at denx.de>
>> >> > Cc: Pantelis Antoniou <pantelis.antoniou at konsulko.com>
>> >> > Cc: Simon Glass <sjg at chromium.org>
>> >> > Cc: Jaehoon Chung <jh80.chung at samsung.com>
>> >> > ---
>> >> > Changes for v4
>> >> > - Calibration only run if node not in DTS
>> >> > Changes for v3
>> >> > - Remove the && ok as its redundant
>> >> > Changes for v2
>> >> > - Using standard error return macro
>> >> > - Split to small function to avoid deep identation
>> >> > - Fix coding standard
>> >> > ---
>> >> >
>> >> >  drivers/mmc/socfpga_dw_mmc.c | 208
>> >> >  ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 205
>> >> >  insertions(+), 3 deletions(-)
>> >>
>> >> Should this code go in the generic dw_mmc.c file instead?
>> >
>> > *Marek grabs popcorn*
>> >
>> > You might want to read the discussion(s) below the previous versions of
>> > the patch, but TLDR, samsung doesn't want the calibration code to
>> > interfere with their driver it seems.
>>
>> OK, fair enough. Let's see what happens when the next person wants to
>> add this feature.
>
> I'm reluctant to grab this patch altogether ... what do you think about this
> functionality ?

It seems reasonable to me - high speed MMC requires it.

Regards,
Simon