[U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22

Alexey Brodkin Alexey.Brodkin at synopsys.com
Mon Nov 30 16:57:12 CET 2015


Hi Tom,

On Mon, 2015-11-30 at 10:56 -0500, Tom Rini wrote:
> On Mon, Nov 30, 2015 at 10:23:20AM +0000, Alexey Brodkin wrote:
> > Hi Joe,
> > 
> > On Thu, 2015-09-03 at 15:46 -0500, Joe Hershberger wrote:
> > > Hi Moritz,
> > > 
> > > On Thu, Sep 3, 2015 at 2:25 PM, Moritz Fischer <moritz.fischer at ettus.com> wrote:
> > > > This patch fixes a bunch of deprecation warings that show up when using
> > > > checkpatch.pl with Perl 5.22.
> > > > 
> > > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > > marked by <-- HERE in m/\#\s*define.*do\s{ <-- HERE / at
> > > > ./scripts/checkpatch.pl line 2829.
> > > > 
> > > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > > marked by <-- HERE in m/\(.*\){ <-- HERE / at
> > > > ./scripts/checkpatch.pl line 3262.
> > > > 
> > > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > > marked by <-- HERE in m/do{ <-- HERE / at
> > > > ./scripts/checkpatch.pl line 3263.
> > > > 
> > > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > > marked by <-- HERE in m/^\({ <-- HERE / at
> > > > ./scripts/checkpatch.pl line 3636.
> > > > 
> > > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > > marked by <-- HERE in m/(?^x:
> > > > 
> > > > Signed-off-by: Moritz Fischer <moritz.fischer at ettus.com>
> > > 
> > > Please submit this and have it accepted in the Linux tree. We will
> > > then pull it in here once it is accepted there.
> > 
> > Similar fix is already in Linus' master tree, see
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4e5d56bdf892e18832a6540b63ebf709966bce2a
> > 
> > Also note:
> >  [1] That commit from Linux tree won't apply cleanly on U-Boot
> >      due to a bit different context.
> >  [2] Even if manually tweaked it looks like it is incomplete:
> >      ------------------->8-------------------
> >      )\(.*\).*\s{ <-- HERE / at scripts/checkpatch.pl line 2828.
> >      ------------------->8-------------------
> > 
> > So with above in mind could you please apply that patch posted by
> > Moritz?
> > 
> > This fixes checkpatch in Fedora 23 - in current state it is way too noisy.
> 
> Maybe we just need to re-sync again?
> 

Do you mean to copy entire checkpatch.pl over from Linux to U-Boot?

-Alexey


More information about the U-Boot mailing list