[U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22

Tom Rini trini at konsulko.com
Mon Nov 30 17:37:37 CET 2015


On Mon, Nov 30, 2015 at 08:06:45AM -0800, Joe Perches wrote:
> On Mon, 2015-11-30 at 10:56 -0500, Tom Rini wrote:
> > On Mon, Nov 30, 2015 at 10:23:20AM +0000, Alexey Brodkin wrote:
> []
> > > Similar fix is already in Linus' master tree, see
> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/comm
> > > it/?id=4e5d56bdf892e18832a6540b63ebf709966bce2a
> > > 
> > > Also note:
> > >  [1] That commit from Linux tree won't apply cleanly on U-Boot
> > >      due to a bit different context.
> > >  [2] Even if manually tweaked it looks like it is incomplete:
> > >      ------------------->8-------------------
> > >      )\(.*\).*\s{ <-- HERE / at scripts/checkpatch.pl line 2828.
> > >      ------------------->8-------------------
> > > 
> > > So with above in mind could you please apply that patch posted by
> > > Moritz?
> > > 
> > > This fixes checkpatch in Fedora 23 - in current state it is way too
> > > noisy.
> > 
> > Maybe we just need to re-sync again?
> 
> I don't track u-boot.
> 
> Are there any u-boot specific changes made to checkpatch
> that are inappropriate for the linux-kernel?
> 
> If there aren't, maybe whatever u-boot changes that have
> been made to checkpatch should be pulled into the kernel
> version.

My memory is hazy, sorry, so I dug this up:
https://lkml.org/lkml/2014/2/24/542 and then re-read most of it.  I had
a newer version of the __packed check that I didn't post (I'm pretty
sure) since the general feedback seemed to be that it wasn't wanted for
the kernel.  Other than that (and some other tiny things that are easy
to fixup) no, we don't have local changes.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151130/1770a909/attachment.sig>


More information about the U-Boot mailing list