[U-Boot] [PATCH 3/3] net: mvneta: Convert to driver model

Joe Hershberger joe.hershberger at gmail.com
Mon Nov 30 23:23:43 CET 2015


On Fri, Nov 27, 2015 at 4:29 AM, Stefan Roese <sr at denx.de> wrote:
> Update this driver to support driver model. As all MVEBU boards using
> this driver are converted with this patch, the non-driver-model code
> can be removed completely. This is also the reason why this patch
> is quite big and includes a) the driver change and b) the
> platform change. As its not git-bisect save otherwise.
>
> With this conversion, some parameters are now extracted from the
> DT instread of using the config header defines. The supported
> properties right now are:
>
> PHY-mode ("phy-mode") and PHY-address ("reg").
>
> The base addresses for the ethernet controllers can be removed from
> the header files as well.
>
> Please note that this patch also removes the E1000 network driver
> from some MVEBU config headers. This is necessary, as with DM_ETH
> configured and the e1000 driver enabled, the PCI driver also needs
> to support DM. But the MVEBU PCI(e) driver still needs to get
> ported to DM. When this is done, the E1000 driver can be enabled
> again.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Luka Perkov <luka.perkov at sartura.hr>
> Cc: Dirk Eibach <dirk.eibach at gdsys.cc>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Simon Glass <sjg at chromium.org>
> ---
>  arch/arm/Kconfig                            |   1 +
>  arch/arm/mach-mvebu/cpu.c                   |  24 ---
>  arch/arm/mach-mvebu/include/mach/soc.h      |   4 -
>  board/Marvell/db-mv784mp-gp/db-mv784mp-gp.c |  32 ++--
>  board/maxbcm/maxbcm.c                       |  20 ++-
>  drivers/net/mvneta.c                        | 230 ++++++++++++++++------------
>  include/configs/db-88f6820-gp.h             |   3 -
>  include/configs/db-mv784mp-gp.h             |   4 -
>  include/configs/maxbcm.h                    |   3 -
>  9 files changed, 154 insertions(+), 167 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 2e20212..0c4794b 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -117,6 +117,7 @@ config ARCH_MVEBU
>         select OF_CONTROL
>         select OF_SEPARATE
>         select DM
> +       select DM_ETH

All ARM boards? Am I missing something? Seems a bit broad for the
scope of this patch.

>         select DM_SERIAL
>         select DM_SPI
>         select DM_SPI_FLASH

Otherwise, looks good.

-Joe


More information about the U-Boot mailing list