[U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer

Wolfgang Denk wd at denx.de
Thu Oct 1 22:07:38 CEST 2015


Dear Jacob,

In message <560D6DE3.8070901 at ti.com> you wrote:
> 
> Yes. However, the global "net_boot_file_name" is not only used for 
> BOOTP, but also for NFS and TFTP.
> 
> "net_boot_file_name" appears to be temporary storage to supply the file 
> path to arbitrary protocols from the command line arguments.

I see.

> The "file" field in the bootp message is fixed at 128 octets in the 
> "bootp_hdr" structure.
> 
> The contents of "net_boot_file_name" are read or written using the 
> standard "strncopy()" or the similar "copy_filename()", so there should 
> be any issue with respect to memory leaks.

I guess you mean there should NOT be any issue?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anarchy may not be the best form of government, but it's better  than
no government at all.


More information about the U-Boot mailing list