[U-Boot] [PATCH] Revert "imx: wdog: correct wcr register settings"

Wolfgang Denk wd at denx.de
Thu Oct 1 22:11:43 CEST 2015


Dear Fabio,

In message <1443727970-10347-1-git-send-email-festevam at gmail.com> you wrote:
> 
> Unlike i.MX, LS1021 uses big-endian ordering for the watchdog
> controller, which means we cannot use the little endian accessors.
...
> -	clrsetbits_le16(&wdog->wcr, 0, WCR_WDE);
> -
> +	writew(WCR_WDE, &wdog->wcr);

I'm sorry, but I fail to understand how writew() can be better than
another I/O accessor.  Neither of these has the capability to detect
the endianess of this specific register interface ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein


More information about the U-Boot mailing list