[U-Boot] [PATCH] fdt: fix fdtdec_get_pci_addr() for CONFIG_PHYS_64BIT

Thierry Reding treding at nvidia.com
Tue Oct 6 11:56:24 CEST 2015


On Fri, Oct 02, 2015 at 05:44:06PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
> 
> PCI addresses are always represented as 3 cells in DT. (one cell for bus
> and device, and two cells for a 64-bit addres). This does not vary based
> on either the physical address size of the CPU, nor any #address-cells
> property in DT (or more precisely, #address-cells must be set to 3 in any
> PCIe controller's node).
> 
> Fix fdtdec_get_pci_addr() to use conversion functions that operate on
> (fixed) cell-sized data rather than (varying) physical-address-sized
> data, so that the function works on 64-bit systems.
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  lib/fdtdec.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

This looks very familiar. I think I used to have an equivalent patch in
my tree, but possibly never sent it out because I never managed to get
PCIe to work. Anyway:

Reviewed-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151006/2aba454e/attachment.sig>


More information about the U-Boot mailing list