[U-Boot] [PATCH 1/2] x86: gpio: Make x86-pinctrl subnode of ich6-gpio

[Simon Glass]

Hi George,

On 7 October 2015 at 16:29, George McCollister
<george.mccollister at gmail.com> wrote:
> Instead of having x86-pinctrl work separately from ich6-gpio have it
> work underneath ich6-gpio. This removes redundant configuration and will
> allow the addition of shared bank settings in future commits.
>
> Signed-off-by: George McCollister <george.mccollister at gmail.com>
> ---
>  arch/x86/dts/minnowmax.dts                         |  96 +++++++++---------
>  arch/x86/include/asm/gpio.h                        |   1 -
>  board/intel/minnowmax/minnowmax.c                  |   9 +-
>  doc/device-tree-bindings/gpio/intel,ich6-gpio.txt  |  14 +++
>  .../gpio/intel,x86-pinctrl.txt                     |  17 ++--
>  drivers/gpio/intel_ich6_gpio.c                     | 107 ++++++++-------------
>  6 files changed, 118 insertions(+), 126 deletions(-)
>  create mode 100644 doc/device-tree-bindings/gpio/intel,ich6-gpio.txt

Conceptually pinmux and GPIO are different concepts. What is the need
to make pinctrl a subset of GPIO? In some ways the opposite would make
more sense.

Perhaps instead we should have a pinctrl driver?

Regards,
Simon