[U-Boot] [PATCH] nios2: set default cache configuration in start.S

Thomas Chou thomas at wytron.com.tw
Fri Oct 9 11:03:36 CEST 2015


Hi Marek,

On 10/09/2015 05:14 AM, Marek Vasut wrote:
> Did I miss the DT part somewhere or is that not part of this patch ?

As we are just barely starting from reset, there is no luxury of DT. 
After this, DT will be used with the cache flush patch.

> Another question I have is -- why don't we set CONFIG_SYS_{I,D}CACHE_SIZE to
> maximum value? This should work for all nios2 cache configurations and it should
> also be correct, no ? Speed might be a bit of an issue here, but I doubt the
> impact would be that large.

I am doing all the best to get rid of the CONFIG_SYS_{I,D}CACHE_SIZE...
So I avoid to use the same macro names. Here I use the maximum value in 
this startup only. The speed penalty is only once here. After we get DT 
initialized, we have the correct values of cache configuration.

It might be awful to use the maximum value all the time. See, we flush 
cache for every eth packet!

Thanks a lot for your review.

Best regards,
Thomas


More information about the U-Boot mailing list