[U-Boot] [PATCH 1/7] sunxi: Kconfig-ify CONFIG_AXP152_POWER and _AXP209_POWER

[Hans de Goede]

Hi,

On 09-10-15 08:49, Ian Campbell wrote:
> On Sat, 2015-10-03 at 16:26 +0200, Hans de Goede wrote:
>> Note that sun5i boards can have either an AXP209 or an AXP152 pmic,
>
> Is it actually xor? I think so given that you later on unify the names
> such that they cannot be compiled in at the same time.
>
> If so then...
>
>> +config AXP152_POWER
>> +	boolean "axp152 pmic support"
>> +	depends on MACH_SUN5I
>> +	---help---
>> +	Say y here to enable support for the axp152 pmic found on
>> most A10s
>> +	boards.
>> +
>> +config AXP209_POWER
>> +	boolean "axp209 pmic support"
>> +	depends on MACH_SUN4I || MACH_SUN5I || MACH_SUN7I
>> +	default y if MACH_SUN4I || MACH_SUN7I
>> +	---help---
>> +	Say y here to enable support for the axp209 pmic found on
>> most
>> +	A10, A13 and A20 boards.
>> +
>>   config AXP221_POWER
>
> ... these three ought to be inside a choice?

I was thinking the same, but on A80 boards there are 2
different axp chips, so if we make this a choice now we
just end up needing to revert this when we get full A80 support.

Regards,

Hans