[U-Boot] [PATCH 2/2] x86: Add SMBIOS table support

[Simon Glass]

Hi Bin,

On 10 October 2015 at 08:13, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Sat, Oct 10, 2015 at 1:20 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Bin,
>>
>> On 10 October 2015 at 04:38, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Fri, Oct 9, 2015 at 9:02 PM, Simon Glass <sjg at chromium.org> wrote:
>>>> Hi Bin,
>>>>
>>>> On 9 October 2015 at 11:17, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>>> System Management BIOS (SMBIOS) is a specification for how
>>>>> motherboard and system vendors present management information
>>>>> about their products in a standard format by extending the BIOS
>>>>> interface on Intel architecture systems. As of today the latest
>>>>> spec is 3.0 and can be downloaded from DMTF website. This commit
>>>>> adds a simple and minimum required implementation.
>>>>>
>>>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>>> ---
>>>>>
>>>>>  arch/x86/Kconfig              |  11 ++
>>>>>  arch/x86/include/asm/smbios.h | 181 +++++++++++++++++++++++++++++++
>>>>>  arch/x86/lib/Makefile         |   1 +
>>>>>  arch/x86/lib/smbios.c         | 242 ++++++++++++++++++++++++++++++++++++++++++
>>>>>  arch/x86/lib/tables.c         |   5 +
>>>>>  doc/README.x86                |   2 -
>>>>>  6 files changed, 440 insertions(+), 2 deletions(-)
>>>>>  create mode 100644 arch/x86/include/asm/smbios.h
>>>>>  create mode 100644 arch/x86/lib/smbios.c
>>
>> [snip]
>>
>>>>> diff --git a/doc/README.x86 b/doc/README.x86
>>>>> index a4f5321..18fed82 100644
>>>>> --- a/doc/README.x86
>>>>> +++ b/doc/README.x86
>>>>> @@ -764,7 +764,6 @@ TODO List
>>>>>  - Audio
>>>>>  - Chrome OS verified boot
>>>>>  - SMI and ACPI support, to provide platform info and facilities to Linux
>>>>> -- Desktop Management Interface (DMI) [15] support
>>>>>
>>>>>  References
>>>>>  ----------
>>>>> @@ -782,4 +781,3 @@ References
>>>>>  [12] http://events.linuxfoundation.org/sites/events/files/slides/chromeos_and_diy_vboot_0.pdf
>>>>>  [13] http://events.linuxfoundation.org/sites/events/files/slides/elce-2014.pdf
>>>>>  [14] doc/device-tree-bindings/misc/intel,irq-router.txt
>>>>> -[15] http://en.wikipedia.org/wiki/Desktop_Management_Interface
>>>>> --
>>>>> 1.8.2.1
>>>>>
>>>>
>>>> It might be worth adding docs to the README about what tables U-Boot
>>>> now supports, how to enable each and what is recommended. There are
>>>> quite a few now. My head is spinning!
>>>>
>>>
>>> Do you mean what tables in SMBIOS spec are supported by U-Boot, or
>>> what tables in PIRQ/MP/ACPI/SMBIOS tables are supported by U-Boot?
>>
>> I mean the latter. There are quite a few tables and it's not clear
>> what should be used/enabled, what tables conflict, what Linux does
>> with them, why it needs them, etc.
>>
>
> OK, maybe we can document this when ACPI support is ready?

Anytime is fine with me.

Regards,
Simon