[U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

[Bin Meng]

Hi Simon,

On Sat, Oct 10, 2015 at 3:31 PM, Simon Glass <sjg at chromium.org> wrote:
> +Bin
>
> Hi George,
>
> On 9 October 2015 at 22:54, George McCollister
> <george.mccollister at gmail.com> wrote:
>> Advantech SOM-6896 is a Broadwell U based COM Express Compact Module
>> Type 6. This patch adds support for it as a coreboot payload.
>>
>> On board SATA and SPI are functional. On board Ethernet isn't functional
>> but since it's optional and ties up a PCIe x4 that is otherwise brought
>> out, this isn't a concern at the moment. USB doesn't work since the
>> xHCI driver appears to be broken.
>>
>> Signed-off-by: George McCollister <george.mccollister at gmail.com>
>> ---
>>  arch/x86/dts/Makefile      |  3 ++-
>>  arch/x86/dts/som-6896.dts  | 43 +++++++++++++++++++++++++++++++++++++++++++
>>  include/configs/som-6896.h | 38 ++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 83 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/x86/dts/som-6896.dts
>>  create mode 100644 include/configs/som-6896.h
>>
>> diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile
>> index 71595c7..9fa2e21 100644
>> --- a/arch/x86/dts/Makefile
>> +++ b/arch/x86/dts/Makefile
>> @@ -6,7 +6,8 @@ dtb-y += bayleybay.dtb \
>>         galileo.dtb \
>>         minnowmax.dtb \
>>         qemu-x86_i440fx.dtb \
>> -       qemu-x86_q35.dtb
>> +       qemu-x86_q35.dtb \
>> +       som-6896.dtb
>
> I'm starting to think we need to name these better. ARM uses the
> <soc>_<board>, so how about broadwell_som-6896.dtb?

I am good with the new name. And should we change defconfig and
config.h to use the same name too?

[snip]

Regards,
Bin