[U-Boot] [PATCH] common/image.c: Make boot_get_ramdisk() perform a check for Android images

Tom Rini trini at konsulko.com
Sun Oct 11 15:09:47 CEST 2015


On Mon, Oct 05, 2015 at 02:23:40PM -0500, Rob Herring wrote:
> On Tue, Sep 1, 2015 at 8:50 AM, Paul Kocialkowski <contact at paulk.fr> wrote:
> > Le jeudi 27 août 2015 à 15:42 -0400, Tom Rini a écrit :
> >> In 2dd4632 the check for where a ramdisk is found on an Android image
> >> was got moved into the "normal" loop here, causing people to have to
> >> pass the kernel address in the ramdisk address location in order to have
> >> Android boot still.  This changed previous behavior so perform a check
> >> early in the function to see if we have an Android image and if so use
> >> that as where to look for the ramdisk (which is what the rest of the
> >> code here expects).
> >
> > That patch does fix my problem (the ramdisk is now correctly passed to
> > the kernel). I suggest that you merge it ASAP.
> 
> Doesn't look like this was ever merged or respun. I had some comments,
> but have no issue if they addressed separately as part of some
> refactoring.

OK.  With respect to the code flow, that's on the "someday, probably"
list.  I've shuffled things around so that you can still provide a
separate ramdisk to override the image as that was the use-case I hadn't
considered before.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151011/45cd43e2/attachment.sig>


More information about the U-Boot mailing list