[U-Boot] [PATCH v3 2/2] ls102xa: Fix reset hang

[Stefano Babic]

Hi Tom,

On 12/10/2015 18:01, Tom Rini wrote:
> On Mon, Oct 12, 2015 at 12:53:12PM -0300, Fabio Estevam wrote:
>> Hi Tom,
>>
>> On Sat, Oct 3, 2015 at 2:21 PM, Fabio Estevam <festevam at gmail.com> wrote:
>>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>>
>>> Since commit 623d96e89aca6("imx: wdog: correct wcr register settings")
>>> issuing a 'reset' command causes the system to hang.
>>>
>>> Unlike i.MX and Vybrid, the watchdog controller on LS102x is big-endian.
>>>
>>> This means that the watchdog on LS1021 has been working by accident as
>>> it does not use the big-endian accessors in drivers/watchdog/imx_watchdog.c.
>>> Commit 623d96e89aca6("imx: wdog: correct wcr register settings") only
>>> revelead the endianness problem on LS102x.
>>>
>>> In order to fix the reset hang, introduce a reset_cpu() implementation that
>>> is specific for ls102x, which accesses the watchdog WCR register in big-endian
>>> format. All that is required to reset LS102x is to clear the SRS bit.
>>>
>>> This approach is a temporary workaround to avoid a regression for LS102x
>>> in the 2015.10 release. The proper fix is to make the watchdog driver
>>> endian-aware, so that it can work for i.MX, Vybrid and LS102x.
>>>
>>> Reported-by: Sinan Akman <sinan at writeme.com>
>>> Tested-by: Sinan Akman <sinan at writeme.com>
>>> Reviewed-by: Wolfgang Denk <wd at denx.de>
>>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> Are you happy with this series?
>>
>> This one fixes a regression, so it would be nice to have it applied in 2015.10.
> 
> Sorry, for some reason I thought it had been picked up already by
> Stefano.

I missed them, as I was not in CC and I was not delegated.

> 
> Stefano, are there any other release critical imx/related changes?  If
> not, I can pickup these two directly, otherwise put together a PR
> please.  Or just put together a PR if you like, thanks!

There are a couple of fixes for imximage - I see you have already picked
up this, so I send my PR with only the imximage fixes.

Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================