[U-Boot] [Patch V5 02/17] common/board_f.c: modify the macro to use get_clocks() more common

[Gong Q.Y.]

> -----Original Message-----
> From: Kushwaha Prabhakar-B32579
> Sent: Friday, October 16, 2015 12:08 PM
> To: Gong Qianyu-B52263; u-boot at lists.denx.de
> Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie Shaohui-
> B21989; Song Wenbin-B53747; Wood Scott-B07421; Wang Huan-B18965; Gong
> Qianyu-B52263
> Subject: RE: [Patch V5 02/17] common/board_f.c: modify the macro to use
> get_clocks() more common
> 
> 
> > -----Original Message-----
> > From: Gong Qianyu [mailto:Qianyu.Gong at freescale.com]
> > Sent: Thursday, October 15, 2015 6:32 PM
> > To: u-boot at lists.denx.de
> > Cc: Hu Mingkai-B21284 <Mingkai.Hu at freescale.com>; Sun York-R58495
> > <yorksun at freescale.com>; Hou Zhiqiang-B48286 <B48286 at freescale.com>;
> > Xie Shaohui-B21989 <Shaohui.Xie at freescale.com>; Song Wenbin-B53747
> > <Wenbin.Song at freescale.com>; Wood Scott-B07421
> > <scottwood at freescale.com>; Kushwaha Prabhakar-B32579
> > <prabhakar at freescale.com>; Wang Huan-B18965
> > <alison.wang at freescale.com>; Gong Qianyu-B52263
> > <Qianyu.Gong at freescale.com>
> > Subject: [Patch V5 02/17] common/board_f.c: modify the macro to use
> > get_clocks() more common
> >
> > get_clocks() should not be limited by ESDHC.
> >
> > Signed-off-by: Gong Qianyu <Qianyu.Gong at freescale.com>
> > ---
> > V5:
> >  - No change.
> > V4:
> >  - No change.
> > V3:
> >  - Removed defines in PPC configs that have no need to use.
> > V2:
> >  - No change.
> >
> >  common/board_f.c                  | 2 +-
> >  include/configs/colibri_vf.h      | 1 +
> >  include/configs/ls1021aqds.h      | 1 +
> >  include/configs/ls1021atwr.h      | 1 +
> >  include/configs/ls2085aqds.h      | 1 +
> >  include/configs/ls2085ardb.h      | 1 +
> >  include/configs/m53evk.h          | 1 +
> >  include/configs/mx25pdk.h         | 1 +
> >  include/configs/mx35pdk.h         | 1 +
> >  include/configs/mx51evk.h         | 1 +
> >  include/configs/mx53ard.h         | 1 +
> >  include/configs/mx53evk.h         | 1 +
> >  include/configs/mx53loco.h        | 1 +
> >  include/configs/mx53smd.h         | 1 +
> >  include/configs/mx6_common.h      | 1 +
> >  include/configs/mx7_common.h      | 1 +
> >  include/configs/usbarmory.h       | 1 +
> >  include/configs/vf610twr.h        | 1 +
> >  include/configs/woodburn_common.h | 1 +
> >  19 files changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/common/board_f.c b/common/board_f.c index
> > 613332e..1bb84b3
> > 100644
> > --- a/common/board_f.c
> > +++ b/common/board_f.c
> > @@ -806,7 +806,7 @@ static init_fnc_t init_sequence_f[] = {  #if
> > defined(CONFIG_BOARD_POSTCLK_INIT)
> >  	board_postclk_init,
> >  #endif
> > -#ifdef CONFIG_FSL_ESDHC
> > +#ifdef CONFIG_FSL_CLK
> >  	get_clocks,
> >  #endif
> 
> New define CONFIG_FSL_CLK used. Please add its description in README file.
> 
> Also, is there no need of  defining CONFIG_FSL_CLK for PowerPC platforms?
> 
> --prabhakar

No. They have already called the first get_clocks() in init_sequence_f[] as they define CONFIG_PPC.
CONFIG_FSL_CLK is then used to call the second get_clocks(), which may be redundant for PPC. 

Regards,
Qianyu