[U-Boot] [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency

Chin Liang See clsee at altera.com
Fri Oct 16 12:13:24 CEST 2015


>From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001
From: Chin Liang See <clsee at altera.com>
Date: Fri, 16 Oct 2015 16:35:10 +0800
Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of
spi-max-frequency

Fix the fdt read for spi-max-frequency as it's contained
in the child node. Current state of code is always
returning default value.

Signed-off-by: Chin Liang See <clsee at altera.com>
Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux at gmail.com>
Cc: Marek Vasut <marex at denx.de>
Cc: Stefan Roese <sr at denx.de>
Cc: Vikas Manocha <vikas.manocha at st.com>
Cc: Jagannadh Teki <jteki at openedev.com>
Cc: Pavel Machek <pavel at denx.de>
Acked-by: Marek Vasut <marex at denx.de>
Acked-by: Pavel Machek <pavel at denx.de>
---
Changes for v4
- use the newly created fdtdec_get_uint
Changes for v3
- Use of fdt_getprop_u32_default_node instead casting
Changes for v2
- Add unsigned casting for plat->max_hz
---
 drivers/spi/cadence_qspi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
index c5a4276..5756178 100644
--- a/drivers/spi/cadence_qspi.c
+++ b/drivers/spi/cadence_qspi.c
@@ -295,10 +295,6 @@ static int cadence_spi_ofdata_to_platdata(struct
udevice *bus)
 	plat->regbase = (void *)data[0];
 	plat->ahbbase = (void *)data[2];
 
-	/* Use 500KHz as a suitable default */
-	plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency",
-				      500000);
-
 	/* All other paramters are embedded in the child node */
 	subnode = fdt_first_subnode(blob, node);
 	if (subnode < 0) {
@@ -306,6 +302,10 @@ static int cadence_spi_ofdata_to_platdata(struct
udevice *bus)
 		return -ENODEV;
 	}
 
+	/* Use 500 KHz as a suitable default */
+	plat->max_hz = fdtdec_get_uint(blob, subnode, "spi-max-frequency",
+				       500000);
+
 	/* Read other parameters from DT */
 	plat->page_size = fdtdec_get_int(blob, subnode, "page-size", 256);
 	plat->block_size = fdtdec_get_int(blob, subnode, "block-size", 16);
-- 
2.2.0




More information about the U-Boot mailing list