[U-Boot] [PATCH 5/5] sbc8641d: enable and test CONFIG_SYS_GENERIC_BOARD

[Paul Gortmaker]

On 2015-10-06 11:27 AM, Paul Gortmaker wrote:
> On 2015-10-05 08:53 PM, Paul Gortmaker wrote:
>> [Re: [U-Boot] [PATCH 5/5] sbc8641d: enable and test CONFIG_SYS_GENERIC_BOARD] On 04/10/2015 (Sun 01:45) Masahiro Yamada wrote:
>>
>  
> [...]
> 
>>
>>>
>>> Any plan about this patch?
>>>
>>> I think this is the last non-generic board for PowerPC architecture.
>>>
>>> This board is still keeping us from removing arch/powerpc/lib/board.c
>>
>> Let me see if I can identify the exact line of change that breaks
>> booting tomorrow, and maybe then Simon or someone can suggest next steps
>> from there.
> 
> So I broke down the suspect patch into three chunks, testing each
> chunk as I went and it booted each time.  A git diff of my split
> by 3 vs a cherry pick of what I thought was the offending commit
> shows nothing.
> 
> So at this point, it seems the bisect returned the wrong result,
> which is odd, since it seemed the same for sbc8548 and sbc8641.
> Maybe a makefile bug let an object file get re-used that should
> not have been?   I'll do distclean in each bisect step in the
> future.
> 
> I'll have another chance to work on this Thurs AM, and I'm curious
> to get to the bottom of this, so I'll follow up then with what I
> find out.

OK. So I finally got to the bottom of this and now it makes more
sense.  The monitor len was set to 256k and we were flirting with
breaking that threshold based on .config settings and where we
were in the tree ; my 2nd bisect led me to 2015.07-ish stuff and
there I saw this when comparing the passing build with the fail:

     u-boot$git describe 6eed3786c68c8a49d
     v2015.07-rc1-412-g6eed3786c68c
                  ^^^
    
     u-boot$ls -l ../41*/u-boot.bin
     -rwxrwxr-x 1 paul paul 261476 Oct 16 16:47 ../411/u-boot.bin
     -rwxrwxr-x 1 paul paul 266392 Oct 16 16:43 ../412/u-boot.bin
     u-boot$bc
     bc 1.06.95
     Copyright 1991-1994, 1997, 1998, 2000, 2004, 2006 Free Software Foundation, Inc.
     This is free software with ABSOLUTELY NO WARRANTY.
     For details type `warranty'.
     256*1024
     262144

The 412 commit added CONFIG_NET to the board and added 5k to the image
which broke the 256k limit.  Not sure why the earlier bisect that led
to Simon's commit was breaking initially, but then not reproducible;
I'm guessing that I wasn't re-running the defconfig step for each bisect
step perhaps?

I'll send a v2 of the series with 384k mon len shortly ; I have it
booting on today's master commit now.

Paul.
--


U-Boot 2015.10-rc5-00024-gefbcba5eb4a0 (Oct 16 2015 - 17:34:32 -0400)

CPU:   8641D, Version: 2.0, (0x80900120)
Core:  e600 Core 0, Version: 2.2, (0x80040202)
Clock Configuration:
       CPU:1000 MHz, MPX:400  MHz
       DDR:200  MHz (400 MT/s data rate), LBC:25   MHz
L1:    D-cache 32 KiB enabled
       I-cache 32 KiB enabled
L2:    512 KiB enabled
I2C:   ready
DRAM:  512 MiB
Flash: 16 MiB
SRIO1: disabled
*** Warning - bad CRC, using default environment

PCIe1: Root Complex, no link, regs @ 0xf8008000
PCIe1: Bus 00 - 00
PCIe2: Root Complex, no link, regs @ 0xf8009000
PCIe2: Bus 01 - 01
In:    serial
Out:   serial
Err:   serial
Net:   eTSEC1 [PRIME]
Error: eTSEC1 address not set.
, eTSEC2
Error: eTSEC2 address not set.
, eTSEC3
Error: eTSEC3 address not set.
, eTSEC4
Error: eTSEC4 address not set.

Hit any key to stop autoboot:  0
=>