[U-Boot] [PATCH v3] nios2: convert cache flush to use dm cpu data

Thomas Chou thomas at wytron.com.tw
Sat Oct 17 08:54:57 CEST 2015


Hi Marek,

On 10/17/2015 07:00 AM, Marek Vasut wrote:
>> +static void __flush_dcache(unsigned long start, unsigned long end)
>> +{
>> +	unsigned long addr;
>> +
>> +	start &= ~(gd->arch.dcache_line_size - 1);
>> +	end += (gd->arch.dcache_line_size - 1);
>> +	end &= ~(gd->arch.dcache_line_size - 1);
>
> I really don't think we should do this alignment here :-(

The rounding to get flush range is necessary to keep it confirm to the 
interface defined in linux/Documentation/cachetlb.txt.

Removing the rounding and adding "range check and keep" is a violation 
to the common interface.

You cannot agree to the common interface and, at the same time, insist 
on changing the definition by your own.

Best regards,
Thomas


More information about the U-Boot mailing list