[U-Boot] [PATCH v3] common: Fix load and entry addresses in FIT image

Simon Glass sjg at chromium.org
Sun Oct 18 14:18:19 CEST 2015


On 9 September 2015 at 12:07, Simon Glass <sjg at chromium.org> wrote:
>
> On Friday, 4 September 2015, York Sun <yorksun at freescale.com> wrote:
> >
> > FIT image supports more than 32 bits in addresses by using #address-cell
> > field. However the address length is not handled when parsing FIT images.
> > Beside, the variable used to host address has "ulong" type. It is OK for
> > the target, but not always enough for host tools such as mkimage. This
> > patch replaces "ulong" with "phys_addr_t" to make sure the address is
> > correct for both the target and the host.
> >
> > Signed-off-by: York Sun <yorksun at freescale.com>
> >
> > ---
> >
> > Changes in v3:
> >   Define PRIpa for host and target in common/image-fit.c so printf works
> >   properly for 32-, 64-bit targets and host tools.
> >
> > Changes in v2:
> >   Make a common function for both load and entry addresses.
> >   Simplify calculation of addresses in a similar way as fdtdec_get_number()
> >   fdtdec_get_number() is not used, or too many files need to be included
> >     and/or twisted for host tool
> >   Continue to use %08llx for print format for load and entry addresses
> >     because %pa does not always work for host tool (mkimage)
> >
> >  common/bootm.c     |   13 +++++----
> >  common/image-fit.c |   81 +++++++++++++++++++++++++++++-----------------------
> >  include/bootm.h    |    6 ++--
> >  include/image.h    |   12 +++++---
> >  4 files changed, 63 insertions(+), 49 deletions(-)
>

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list