[U-Boot] [PATCH v3 7/8] zynq: Move SPL console init out of board_init_f()

Albert ARIBAUD albert.u.boot at aribaud.net
Sun Oct 18 18:36:21 CEST 2015


Hello Simon,

On Sat, 17 Oct 2015 15:07:00 -0600, Simon Glass <sjg at chromium.org>
wrote:
> We should not init the console this early and there is no need to. If we want
> to do early init it can be done in spl_board_init(). Move the
> preloader_console_init() call from board_init_f() to board_init_r().
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Tested-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> Tested-by: Michal Simek <michal.simek at xilinx.com>

I personally think that we should, almost must in fact, initialize the
console as early as possible.

What exactly is the drawaback of initializing the console here?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list