[U-Boot] [PATCH] nios2: zap nios2-generic board dir

Thomas Chou thomas at wytron.com.tw
Mon Oct 19 01:41:48 CEST 2015


Hi Marek,

On 10/18/2015 11:35 PM, Marek Vasut wrote:
>> +config SYS_CONFIG_NAME
>> +	string "Board header file"
>> +	help
>> +	  This option should contain the base name of board header file.
>> +	  The header file include/configs/<CONFIG_SYS_CONFIG_NAME>.h
>> +	  should be included from include/config.h.
>
> I suspect we don't want this, since we're probing from DT. This option
> should default to something like include/configs/nios2.h , no ?

This is needed as the Kconfig doesn't cover every config option yet. We 
still need a per board file. But this is supposed to be removed when 
Kconfig is done for every option.

Now, the legacy board header, defconfig and dts are all that we need to 
add a new board to nios2. I should add a README.nios2 after I finished 
the conversion of altera_tse to driver model.

>
>>   endmenu
>> diff --git a/arch/nios2/config.mk b/arch/nios2/config.mk
>> index 82bd887..2abad3f 100644
>> --- a/arch/nios2/config.mk
>> +++ b/arch/nios2/config.mk
>> @@ -10,10 +10,11 @@ ifeq ($(CROSS_COMPILE),)
>>   CROSS_COMPILE := nios2-elf-
>>   endif
>>
>> -CONFIG_STANDALONE_LOAD_ADDR ?= 0x02000000
>> +CONFIG_STANDALONE_LOAD_ADDR ?= 0xd2000000
>
> This doesn't look like a removal of generic board ;-)
>
>>   PLATFORM_CPPFLAGS += -D__NIOS2__
>>   PLATFORM_CPPFLAGS += -G0
>> +PLATFORM_CPPFLAGS += -mno-hw-div -mno-hw-mul
>
> This doesn't look that way either, you might want to split this patch
> into a series.

Yes. I will split them. Thanks a lot for your review.

Best regards,
Thomas


More information about the U-Boot mailing list