[U-Boot] [PATCH 07/13] x86: Use struct mrc_region to describe a mrc region

[Bin Meng]

Hi Simon,

On Mon, Oct 19, 2015 at 4:26 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 11 October 2015 at 22:37, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Currently struct fmap_entry is used to describe a mrc region.
>> However this structure contains some other fields that are not
>> related to mrc cache and causes confusion. Besides, it does not
>> include a base address field to store SPI flash's base address.
>> Instead in the mrccache.c it tries to use CONFIG_ROM_SIZE to
>> calculate the SPI flash base address, which unfortunately is
>> not 100% correct as CONFIG_ROM_SIZE may not match the whole
>> SPI flash size.
>
> I'm still not comfortable with CONFIG_ROM_SIZE not being the size of
> the SPI flash. It just seems wrong. Maybe we should have a
> u-boot.rom.min with a minimal images?
>

As we discussed before, we can just document this in README.x86?

>>
>> Define a new struct mrc_region and use it instead.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  arch/x86/cpu/ivybridge/sdram.c  |  2 +-
>>  arch/x86/include/asm/mrccache.h | 13 +++++++++----
>>  arch/x86/lib/mrccache.c         | 27 +++++++++++++++++----------
>>  3 files changed, 27 insertions(+), 15 deletions(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>

Regards,
Bin