[U-Boot] [PATCH 4/9] x86: ivybridge: Use 'ret' instead of 'rcode'

Bin Meng bmeng.cn at gmail.com
Mon Oct 19 04:23:11 CEST 2015


On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass <sjg at chromium.org> wrote:
> For consistency, use 'ret' to handle a return value.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/cpu/ivybridge/sdram.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/cpu/ivybridge/sdram.c b/arch/x86/cpu/ivybridge/sdram.c
> index fc66a3c..26e2e5b 100644
> --- a/arch/x86/cpu/ivybridge/sdram.c
> +++ b/arch/x86/cpu/ivybridge/sdram.c
> @@ -93,11 +93,11 @@ static int read_seed_from_cmos(struct pei_data *pei_data)
>  {
>         u16 c1, c2, checksum, seed_checksum;
>         struct udevice *dev;
> -       int rcode = 0;
> +       int ret = 0;
>
> -       rcode = uclass_get_device(UCLASS_RTC, 0, &dev);
> -       if (rcode) {
> -               debug("Cannot find RTC: err=%d\n", rcode);
> +       ret = uclass_get_device(UCLASS_RTC, 0, &dev);
> +       if (ret) {
> +               debug("Cannot find RTC: err=%d\n", ret);
>                 return -ENODEV;
>         }
>
> @@ -170,11 +170,11 @@ static int write_seeds_to_cmos(struct pei_data *pei_data)
>  {
>         u16 c1, c2, checksum;
>         struct udevice *dev;
> -       int rcode = 0;
> +       int ret = 0;
>
> -       rcode = uclass_get_device(UCLASS_RTC, 0, &dev);
> -       if (rcode) {
> -               debug("Cannot find RTC: err=%d\n", rcode);
> +       ret = uclass_get_device(UCLASS_RTC, 0, &dev);
> +       if (ret) {
> +               debug("Cannot find RTC: err=%d\n", ret);
>                 return -ENODEV;
>         }
>
> --

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list