[U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.

Vadzim Dambrouski pftbest at gmail.com
Mon Oct 19 12:00:32 CEST 2015


On 19.10.2015 09:06, Albert ARIBAUD wrote:
> Hello Vadzim,
>
> On Mon, 19 Oct 2015 00:13:29 +0300, Vadzim Dambrouski
> <pftbest at gmail.com> wrote:
>> Signed-off-by: Vadzim Dambrouski <pftbest at gmail.com>
>> ---
>>
>>   arch/arm/lib/semihosting.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c
>> index ed5e8e4..6541cb4 100644
>> --- a/arch/arm/lib/semihosting.c
>> +++ b/arch/arm/lib/semihosting.c
>> @@ -92,7 +92,7 @@ static long smh_read(long fd, void *memp, size_t len)
>>   		size_t len;
>>   	} read;
>>
>> -	debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, len);
>> +	debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, (ulong)len);
>>
>>   	read.fd = fd;
>>   	read.memp = memp;
>> @@ -107,7 +107,7 @@ static long smh_read(long fd, void *memp, size_t len)
>>   		 * with an error message.
>>   		 */
>>   		printf("%s: ERROR ret %ld, fd %ld, len %lu memp %p\n",
>> -		       __func__, ret, fd, len, memp);
>> +		       __func__, ret, fd, (ulong)len, memp);
>>   		return -1;
>>   	}
>
> len is a size_t; it should not be force-converted into a long, it
> should be printed using a 'z' qualifier.
>
> Amicalement,
>

Well, you are right, I'll send another revision of this patch set.
Thank you for all your assistance.

Regards,
Vadzim Dambrouski


More information about the U-Boot mailing list