[U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

[Richard Weinberger]

Am 19.10.2015 um 15:47 schrieb Ezequiel Garcia:
> After some further investigation, printing the counters as Richard suggested
> I found it was a bug on my side :-( The Linux partition and the U-Boot partition
> had different size (i.e. PEB count) and so Fastmap complained :-(
> 
> We trimmed the Linux partition size, and forgot to change U-Boot's
> (or thought it wouldn't matter).
> 
> Sorry for the noise guys!

Good to know. :)

Let me find a way to detect and report this kind of user error
better.
The WARN_ON() is only meant for bad internal errors.

> Linux WARN_xxx macros return a value, and so can be used inside
> if statements. U-Boot on the other side, just prints a warning:
> 
> #define WARN_ON(x) if (x) {printf("WARNING in %s line %d\n" \
>                                   , __FILE__, __LINE__); }
> 
> AFAICS, the above ifndef __UBOOT__ is needed, unless you fix
> your WARN_ON in U-Boot.

+1

Thanks,
//richard