[U-Boot] [PATCH 2/2] ARM: dra7xx_evm: Add DFU support for qspi flash

[Lukasz Majewski]

Hi Vignesh,

> This adds support to update firmware on qspi flash using DFU.
> 
> On device:
> => setenv dfu_alt_info ${dfu_alt_info_qspi}
> => dfu 0 sf 0:0
> 
> On host:
> $ sudo dfu-util -l
> $ sudo dfu-util -D MLO -a MLO
> $ sudo dfu-util -D u-boot.img -a u-boot.img

This patch series seems ok. I just have one question regarding dfu-util:

sudo dfu-util -D MLO -a MLO

Is the above correct?

Shouldn't it be sudo dfu-util -a 0 -D MLO 
where alt setting 0 corresponds to MLO?

> 
> Signed-off-by: Vignesh R <vigneshr at ti.com>
> ---
>  include/configs/dra7xx_evm.h | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/dra7xx_evm.h
> b/include/configs/dra7xx_evm.h index 6e32de854619..cb9544b49efb 100644
> --- a/include/configs/dra7xx_evm.h
> +++ b/include/configs/dra7xx_evm.h
> @@ -82,11 +82,24 @@
>  	"fdt ram 0x80f80000 0x80000;" \
>  	"ramdisk ram 0x81000000 0x4000000\0"
>  
> +#define DFU_ALT_INFO_QSPI \
> +	"dfu_alt_info_qspi=" \
> +	"MLO raw 0x0 0x010000;" \
> +	"MLO.backup1 raw 0x010000 0x010000;" \
> +	"MLO.backup2 raw 0x020000 0x010000;" \
> +	"MLO.backup3 raw 0x030000 0x010000;" \
> +	"u-boot.img raw 0x040000 0x0100000;" \
> +	"u-boot-spl-os raw 0x140000 0x080000;" \
> +	"u-boot-env raw 0x1C0000 0x010000;" \
> +	"u-boot-env.backup raw 0x1D0000 0x010000;" \
> +	"kernel raw 0x1E0000 0x800000\0"
> +
>  #define DFUARGS \
>  	"dfu_bufsiz=0x10000\0" \
>  	DFU_ALT_INFO_MMC \
>  	DFU_ALT_INFO_EMMC \
> -	DFU_ALT_INFO_RAM
> +	DFU_ALT_INFO_RAM \
> +	DFU_ALT_INFO_QSPI
>  
>  /* Fastboot */
>  #define CONFIG_USB_FUNCTION_FASTBOOT
> @@ -207,6 +220,7 @@
>  
>  #define CONFIG_DFU_MMC
>  #define CONFIG_DFU_RAM
> +#define CONFIG_DFU_SF
>  
>  /* SATA */
>  #define CONFIG_BOARD_LATE_INIT



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group