[U-Boot] [PATCH V2 03/14] xfi3: correct function name

Stefano Babic sbabic at denx.de
Tue Oct 20 15:10:38 CEST 2015


On 20/10/2015 13:39, Peng Fan wrote:
> board_mxsfb_system_setup shoule be named mxsfb_system_setup.
				^---should

But really it is better *must*, else it is dead code as we currently have.

> 
> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
> Cc: Marek Vasut <marek.vasut at gmail.com>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
> 
> V2:
>  none
> 
>  board/creative/xfi3/xfi3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/creative/xfi3/xfi3.c b/board/creative/xfi3/xfi3.c
> index 1d83ea8..509c671 100644
> --- a/board/creative/xfi3/xfi3.c
> +++ b/board/creative/xfi3/xfi3.c
> @@ -163,7 +163,7 @@ static const struct {
>  	{ 0x21, 0,  0x0000 },
>  };
>  
> -void board_mxsfb_system_setup(void)
> +void mxsfb_system_setup(void)
>  {
>  	struct mxs_lcdif_regs *regs = (struct mxs_lcdif_regs *)MXS_LCDIF_BASE;
>  	int i;
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list