[U-Boot] Bisected broken Ethernet support on ODROID-X (Exynos4412 board)

[Siarhei Siamashka]

Hello,

Ethernet support does not work anymore when using the current U-Boot
(version v2014.10) on the ODROID-X board. Bisecting shows that this
happened starting from commit 874dde80169e0a0c00020e2e0bbcd380c61097e3
("dm: usb: exynos: Use driver model for USB"):
    http://git.denx.de/?p=u-boot.git;a=commitdiff;h=874dde80169e0a0c00020e2e0bbcd380c61097e3

Below are the logs from the serial console.

=== works properly ==

U-Boot 2015.04-00271-g52e6935-dirty (Oct 20 2015 - 16:38:09)

CPU:    Exynos4412 at 1000MHz
Model: Odroid based on Exynos4412
DRAM:  1 GiB
Board PMIC init
MMC:   SAMSUNG SDHCI: 0, EXYNOS DWMMC: 1
Net:   No ethernet found.
Hit any key to stop autoboot:  0 
reading boot.scr
129 bytes read in 11 ms (10.7 KiB/s)
## Executing script at 40408000
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 4 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found
       scanning usb for ethernet devices... 1 Ethernet Device(s) found

=== fails ==

U-Boot 2015.04-00273-g78ab40b-dirty (Oct 20 2015 - 16:41:11)

CPU:    Exynos4412 at 1000MHz
Model: Odroid based on Exynos4412
DRAM:  1 GiB
Board PMIC init
MMC:   SAMSUNG SDHCI: 0, EXYNOS DWMMC: 1
Net:   No ethernet found.
Hit any key to stop autoboot:  0 
reading boot.scr
129 bytes read in 12 ms (9.8 KiB/s)
## Executing script at 40408000
starting USB...
USB-1:   USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
       scanning usb for ethernet devices... 0 Ethernet Device(s) found

===

As a test, reverting f56da290b8df14a058b43735494dbbb0f8521a89 ("Drop
the code that doesn't use driver model for USB.") and disabling
CONFIG_DM_USB in odroid_defconfig makes it work again.


-- 
Best regards,
Siarhei Siamashka