[U-Boot] [PATCH 1/2] usb: host: xhci-omap: fix build break

[Tom Rini]

On Wed, Oct 21, 2015 at 09:37:13AM +0100, Peter Robinson wrote:
> >>> Felipe Balbi <balbi at ti.com> writes:
> >>> > Fix the following build break:
> >>> >
> >>> > drivers/usb/host/xhci-omap.c:35:5: error: ‘board_usb_init’ aliased to external symbol ‘__board_usb_init’
> >>> >  int board_usb_init(int index, enum usb_init_type init)
> >>> >       ^
> >>> >
> >>> > Signed-off-by: Felipe Balbi <balbi at ti.com>
> >>>
> >>> ping
> >>
> >> Where / how do I trigger this (or 2/2) ?
> >
> > GCC 5
> 
> I'm seeing exactly the same issue with gcc5 on Fedora, I've also seen
> another issue with gcc5 with strcat for panda board variant names
> which we hacked around [1].

So, I want to say that GCC 5.x (or at least 5.1) will be a known good
compiler for v2016.01.  I know that Fedora folks have been doing it for
a while (yay, thanks) but I also know that Felipe has seen a few
problems using some other (I think..) gcc-5 toolchain.  So what I'm
doing is getting the Fedora gcc-5 packages installed now, along with a
Debian/unstable chroot where I can also get at all of their cross tools.

> [1] http://pkgs.fedoraproject.org/cgit/uboot-tools.git/tree/0009-ARM-fix-pandaboard-es-and-a4-revision-ID.patch?h=f23

That's interesting.  I don't know why (and I would worry about) strcat
failing, but since it's two string literals can't we just do a simple +?
Or is my lack of coffee just yet causing me to forget that C is not
every-other-language...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151021/440bd7bb/attachment.sig>