[U-Boot] [PATCH v2 09/14] fastboot: Implement NAND backend

[Tom Rini]

On Wed, Oct 21, 2015 at 04:57:04PM +0200, Maxime Ripard wrote:
> Hi Tom,
> 
> On Tue, Oct 20, 2015 at 03:46:36PM -0400, Tom Rini wrote:
> > On Thu, Oct 15, 2015 at 02:34:17PM +0200, Maxime Ripard wrote:
> > 
> > > So far the fastboot code was only supporting MMC-backed devices for its
> > > flashing operations (flash and erase).
> > > 
> > > Add a storage backend for NAND-backed devices.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > 
> > This is mutually exclusive with MMC support, right?  If so, it's not
> > quite written that way in the #ifdef's so I think it need to be down in
> > say:
> > 
> > > @@ -569,6 +572,11 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req)
> > >  			   (void *)CONFIG_FASTBOOT_BUF_ADDR,
> > >  			   download_bytes, response);
> > >  #endif
> > > +#ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV
> > > +	fb_nand_flash_write(cmd, fastboot_flash_session_id,
> > > +			    (void *)CONFIG_FASTBOOT_BUF_ADDR,
> > > +			    download_bytes, response);
> > > +#endif
> > 
> > With #elif/#error "Fastboot enabled but without any backing store
> > support" and we drop the #error once this is Kconfig'zied.
> 
> We said in the precedent version that the end goal would be to support
> both at the same time, if relevant.
> 
> I was willing to treat that as a followup patch, but I guess I should
> do as you suggest for the time being.

Yeah, we want to make sure that until it's supported it can't be
configured to try and do it.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151021/562f4df1/attachment.sig>