[U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180

[Tom Warren]

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Wednesday, October 21, 2015 4:11 PM
> To: Tom Warren <TWarren at nvidia.com>
> Cc: u-boot at lists.denx.de; Simon Glass <sjg at chromium.org>; Stephen Warren
> <swarren at nvidia.com>; Thierry Reding <treding at nvidia.com>
> Subject: Re: [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180
> 
> On 10/21/2015 05:03 PM, Tom Warren wrote:
> > Stephen,
> >
> >> -----Original Message-----
> >> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> >> Sent: Monday, October 05, 2015 4:03 PM
> >> To: u-boot at lists.denx.de; Simon Glass <sjg at chromium.org>; Tom Warren
> >> <TWarren at nvidia.com>; Stephen Warren <swarren at nvidia.com>
> >> Cc: Thierry Reding <treding at nvidia.com>
> >> Subject: [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180
> >>
> >> From: Stephen Warren <swarren at nvidia.com>
> >>
> >> p2371-2180 has two PCI ports; a regular x4 slot and a x1 M.2 slot.
> >> This patch adds the relevant DT to enable the PCI controller and
> >> configure the XUSB padctl pin muxing, and code to turn on the PCI
> >> power and enable PCI features in U- Boot. I have only tested the x4 slot.
> >>
> >> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> >
> > This breaks the P2371-2180 build with this error:
> >
> > drivers/net/rtl8169.c: In function 'rtl_recv':
> > drivers/net/rtl8169.c:584:25: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> >    return rtl_recv_common((pci_dev_t)dev->priv, dev->iobase, NULL);
> >                           ^
> > drivers/net/rtl8169.c: In function 'rtl_send':
> > drivers/net/rtl8169.c:669:25: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> >    return rtl_send_common((pci_dev_t)dev->priv, dev->iobase, packet,
> >                           ^
> > drivers/net/rtl8169.c: In function 'rtl_reset':
> > drivers/net/rtl8169.c:849:23: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> >    rtl8169_common_start((pci_dev_t)dev->priv, dev->enetaddr);
> >
> > I've taken my current u-boot-tegra/master, rebased against u-boot/master,
> added your armv8 NONCACHED_MEMORY patchset, then your PLLE, XUSB and
> PCI patchsets. Here are the top commits:
> ...
> 
> You're missing the following two:
> 
> net: rtl8169: Build warning fixes for 64-bit
> fdt: fix fdtdec_get_pci_addr() for CONFIG_PHYS_64BIT
Actually the 'net: rtl8169' patch is in there (brought in from my rebase w/u-boot/master this morning), but the 'fix fdtdec_get_pci_addr' patch isn't. Looks like it is assigned to Simon in Patchwork, and hasn't been applied yet (as of when I pulled down u-boot/master several hours ago). I'll check again, and apply it myself to get the build working if needed so I can do some testing.

Thanks
--
nvpublic
> 
> (see note below --- in patch 1)
> 
> I think everything else required is in your list.