[U-Boot] [PATCH v1 01/12] rockchip: define SUPPORT_SPL and SPL config in RK3288 config

[Simon Glass]

Hi Lin,

On 22 October 2015 at 18:50, hl <hl at rock-chips.com> wrote:
>
> Hi Simon,
>
>
> On 22/10/15 22:07, Simon Glass wrote:
>>
>> Hi Lin,
>>
>> On 20 October 2015 at 20:37, Lin Huang <hl at rock-chips.com> wrote:
>>>
>>> it may not use SPL in other rockchip SOC, so move SUPPORT_SPL and
>>> SPL config to rk3288 configuration.
>>>
>>> Signed-off-by: Lin Huang <hl at rock-chips.com>
>>> ---
>>> Changes in v1: None
>>>
>>>   arch/arm/Kconfig               | 2 --
>>>   arch/arm/mach-rockchip/Kconfig | 2 ++
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index 194fb7b..40fa741 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -831,8 +831,6 @@ config TARGET_STM32F429_DISCOVERY
>>>
>>>   config ARCH_ROCKCHIP
>>>          bool "Support Rockchip SoCs"
>>> -       select SUPPORT_SPL
>>> -       select SPL
>>>          select OF_CONTROL
>>>          select CPU_V7
>>>          select DM
>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>> index ab50f4e..15cd380 100644
>>> --- a/arch/arm/mach-rockchip/Kconfig
>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>> @@ -2,6 +2,8 @@ if ARCH_ROCKCHIP
>>>
>>>   config ROCKCHIP_RK3288
>>>          bool "Support Rockchip RK3288"
>>> +       select SUPPORT_SPL
>>> +       select SPL
>>>          help
>>>            The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
>>>            including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
>>> --
>>> 1.9.1
>>>
>> We should avoid little binary blobs for booting the chip. I think we
>> can live with this as a stepping stone to having a proper SPL, but
>> what is the plan for a proper SPL in U-Boot?
>
>
>     Since rk3036 only 8K SRAM space, so there is not enough space to
>     use SPL to boot up Soc(i try to reduce spl space before, but it still too large for 8K),
>     so i think rk3036 will use little binary blobs booting the soc, not use SUPPORT_SPL and
>     SPL config, this is why i move these two config to sepcific Soc config.

I'd like to push on this a bit. It would be fine to have SPL just be
any program that works - it does not need to load U-Boot, or enable
SUPPORT_SPL, etc. Any source file implementation is going to be better
than a binary blob. The U-Boot build system allows you to create any
SPL image you like.

Regards,
Simon