[U-Boot] [PATCH 3/5] splash_source: add support for filesystem formatted usb

Igor Grinberg grinberg at compulab.co.il
Fri Oct 23 15:12:01 CEST 2015


On 10/23/15 13:23, Nikita Kiryanov wrote:
> On Wed, Oct 21, 2015 at 04:01:46PM +0300, Igor Grinberg wrote:
>> On 08/30/15 11:42, Nikita Kiryanov wrote:
>>> Add support for loading splash image from USB drive formatted with a
>>> filesystem.
>>>
>>> Cc: Igor Grinberg <grinberg at compulab.co.il>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
>>
>> [...]
>>
>>> +#ifdef CONFIG_USB_STORAGE
>>> +	if (location->storage == SPLASH_STORAGE_USB) {
>>> +		usb_init();
>>> +		usb_stor_scan(1);
>>> +	}
>>> +#endif
>>
>> Can we use IS_ENABLED() stuff here instead?
> 
> IS_ENABLED() does not prevent compile errors, only closes off certain
> code paths.

Ok. Any other ways to not have that ifdefferry inside functions?


-- 
Regards,
Igor.


More information about the U-Boot mailing list