[U-Boot] [PATCH] env_ubi.c: Correct pointer error in env load
Kevin Smith
kevin.smith at elecsyscorp.com
Fri Oct 23 19:51:47 CEST 2015
The variable "buf" in this function is a char array, and the
function ubi_volume_read is expecting a char *. In the call, the
address of the pointer is being taken, incorrectly passing a
char **. The compiler warning was being silenced by the cast.
Remove the address operator and the cast.
Signed-off-by: Kevin Smith <kevin.smith at elecsyscorp.com>
Cc: Joe Hershberger <joe.hershberger at ni.com>
Cc: Tom Rini <trini at konsulko.com>
---
common/env_ubi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/common/env_ubi.c b/common/env_ubi.c
index e0dc5af..e611199 100644
--- a/common/env_ubi.c
+++ b/common/env_ubi.c
@@ -181,8 +181,7 @@ void env_relocate_spec(void)
return;
}
- if (ubi_volume_read(CONFIG_ENV_UBI_VOLUME, (void *)&buf,
- CONFIG_ENV_SIZE)) {
+ if (ubi_volume_read(CONFIG_ENV_UBI_VOLUME, buf, CONFIG_ENV_SIZE)) {
printf("\n** Unable to read env from %s:%s **\n",
CONFIG_ENV_UBI_PART, CONFIG_ENV_UBI_VOLUME);
set_default_env(NULL);
--
2.4.6
More information about the U-Boot
mailing list