[U-Boot] [PATCH v9 1/4] include: Add log2 and generic bitops header files

Jagan Teki jteki at openedev.com
Sat Oct 24 05:49:21 CEST 2015


On 22 October 2015 at 17:18, Fabio Estevam <festevam at gmail.com> wrote:
> On Thu, Oct 22, 2015 at 9:28 AM, Fabio Estevam <festevam at gmail.com> wrote:
>> On Thu, Oct 22, 2015 at 8:25 AM, Jagan Teki <jteki at openedev.com> wrote:
>>> On 20 October 2015 at 18:33, Fabio Estevam <fabio.estevam at freescale.com> wrote:
>>>> Use the log2 and generic bitops header files directly from the kernel.
>>>
>>> Pls- add separate patches for log2 and biptops, do remember that use
>>> same Linux approach but don't add unneeded definitions now will add
>>> based on the need.
>>
>> I cannot only add log2 definition without the bitops, as ilog2 needs them.
>>
>> Also, I am not adding unneeded definitions. All the header files I
>> added are referenced.
>
> Or are you suggesting to do like this?
>
> - Patch 1: only add log2 header from the kernel
> - Patch 2: only add bitops headers from the kernel
> - Patch 3: Add the users for log2 and bitops headers

May be you can go-ahead with these but pls- don't add unnecessary code
which we may add it later based on the need.

thanks!
-- 
Jagan | openedev.


More information about the U-Boot mailing list