[U-Boot] Fix bad return value checks (detected with Coccinelle)

Tom Rini trini at konsulko.com
Sat Oct 24 23:15:06 CEST 2015


On Tue, Aug 25, 2015 at 05:09:40PM +0200, Thomas Huth wrote:

> In the "Getting Started with Coccinelle - KVM edition" presentation that
> has been held by Julia Lawall at the KVM forum 2015 (see the slides at
> http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
> she pointed out some bad return value checks in U-Boot that can be
> detected with Coccinelle by using the following config file:
> 
> @@
> identifier x,y;
> identifier f;
> statement S;
> @@
> x = f(...);
> (
>  if (x < 0) S
> |
>  if (
> -     y
> +     x
>  < 0) S
> )
> 
> This patch now fixes these issues.
> 
> Signed-off-by: Thomas Huth <huth at tuxfamily.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151024/410a70ca/attachment.sig>


More information about the U-Boot mailing list