[U-Boot] [U-Boot, V2, 3/3] fs-test.sh: fix pre-requisite detection

Tom Rini trini at konsulko.com
Sat Oct 24 23:15:46 CEST 2015


On Sat, Oct 03, 2015 at 01:56:48PM -0600, Stephen Warren wrote:

> In the following snippet:
> 
> if [ ! -x `which $prereq` ]; then
> 
> When $prereq does not exist, `which $prereq` evaluates to the empty string,
> which results in *no* argument being passed to the -x operator, which then
> evaluates to true, which is the equivalent of the prereq having been found. In
> order for this to fail as expected, we must pass an empty argument, which then
> causes -x to fail. Do this by wrapping the `` in quotes so there's always an
> argument to -x, even if the value of the argument is zero-length.
> 
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Tested-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151024/2b77b683/attachment.sig>


More information about the U-Boot mailing list